[FFmpeg-devel] [PATCH] Fix compilation with --disable-optimizations, h264 enabled but svq3 disabled

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Tue, May 25, 2010 at 10:35:43AM +0300, Martin Storsj? wrote:
>> Hi,
>> 
>> This patch helps the compiler do dead code elimination of svq3 function 
>> branches in the common code at lower optimization levels, too. is_h264 is 
>> initialized with !CONFIG_SVQ3_DECODER || ..., but gcc doesn't seem to be 
>> able to propagate this as a constant when using --disable-optimizations.
>> 
>> // Martin
>>  h264.c |    8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>> 10052f75cd812975e697ad6127982bee4cfd4416  0001-Fix-compilation-with-disable-optimizations-disable-d.patch
>> From 5c33052e20b62d87db5527f3d5ff2b76442b1e98 Mon Sep 17 00:00:00 2001
>> From: Martin Storsjo <martin at martin.st>
>> Date: Tue, 25 May 2010 10:30:49 +0300
>> Subject: [PATCH] Fix compilation with --disable-optimizations --disable-decoders --enable-decoder=h264
>> 
>> !CONFIG_SVQ3_DECODER is already part in is_h264, but gcc doesn't
>> seem to propagate it, in order to do dead code elimination of these
>> branches, at the optimization level set by --disable-optimizations.
>
> i think its cleaner to force enable CONFIG_SVQ3_DECODER if optimizations
> are disabled

Or just leave it as is.

-- 
M?ns Rullg?rd
mans at mansr.com