[FFmpeg-devel] [PATCH]Silence force_align_arg_pointer warning

[Måns Rullgård]

Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> M?ns Rullg?rd <mans <at> mansr.com> writes:
>
>> > Index: libavutil/internal.h
>> > ===================================================================
>> > --- libavutil/internal.h	(revision 23253)
>> > +++ libavutil/internal.h	(working copy)
>> > @@ -39,7 +39,7 @@
>> >  #include "timer.h"
>> >
>> >  #ifndef attribute_align_arg
>> > -#if (!defined(__ICC) || __ICC > 1110) && AV_GCC_VERSION_AT_LEAST(4,2)
>> > +#if ARCH_X86_32 && (!defined(__ICC) || __ICC > 1110) &&
> AV_GCC_VERSION_AT_LEAST(4,2)
>> >  #    define attribute_align_arg __attribute__((force_align_arg_pointer))
>>
>> Rejected.  If gcc starts supporting that attribute on non-x86 we'll
>> surely forget to update this, assuming we even notice.
>
> I thought this has nothing to do with gcc, but with x86-32 being the
> only architecture where an increased alignment is necessary under
> some circumstances.

ARM could certainly use it.  The ABI requires only 8 bytes alignment,
while some NEON instructions need 16 bytes.

-- 
M?ns Rullg?rd
mans at mansr.com