[FFmpeg-devel] [PATCH]Silence force_align_arg_pointer warning

[Måns Rullgård]

Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> Hi!
>
> Attached patch fixes a warning that nearly every FATE configuration shows, 
> including PowerPC, Alpha, ARMv7, AVR32, Sparc, MIPS, ARMv5TE, ia64, PA-RISC 
> and Blackfin.
>
> /misc/fate/redpole/source/libavcodec/utils.c:463: 
> warning: 'force_align_arg_pointer' attribute directive ignored
>
> Please comment, Carl Eugen
>
> Index: libavutil/internal.h
> ===================================================================
> --- libavutil/internal.h	(revision 23253)
> +++ libavutil/internal.h	(working copy)
> @@ -39,7 +39,7 @@
>  #include "timer.h"
>
>  #ifndef attribute_align_arg
> -#if (!defined(__ICC) || __ICC > 1110) && AV_GCC_VERSION_AT_LEAST(4,2)
> +#if ARCH_X86_32 && (!defined(__ICC) || __ICC > 1110) && AV_GCC_VERSION_AT_LEAST(4,2)
>  #    define attribute_align_arg __attribute__((force_align_arg_pointer))
>  #else
>  #    define attribute_align_arg

Rejected.  If gcc starts supporting that attribute on non-x86 we'll
surely forget to update this, assuming we even notice.

-- 
M?ns Rullg?rd
mans at mansr.com