[FFmpeg-devel] [PATCH 11/13] Make nut muxer try to get the codec id from ff_raw_pixelFormatTags if ff_codec_get_id() cannot find it.

[Michael Niedermayer]

On Sat, May 22, 2010 at 06:04:35PM +0200, Stefano Sabatini wrote:
> On date Friday 2010-05-21 19:45:22 +0200, Michael Niedermayer encoded:
> > On Fri, May 21, 2010 at 01:19:06AM +0200, Stefano Sabatini wrote:
> > > On date Monday 2010-05-17 01:15:26 +0200, Michael Niedermayer encoded:
> > > > On Sat, May 15, 2010 at 04:43:31PM +0200, Stefano Sabatini wrote:
> > > > > On date Monday 2010-05-10 00:14:47 +0200, Michael Niedermayer encoded:
> > > > > > On Sun, May 09, 2010 at 04:29:29PM +0200, Stefano Sabatini wrote:
> > [...]
> > 
> > > > > > the codec tag/id mapping must be in AVOutputFormat.codec_tag
> > > > > 
> > > > > Yes but what about codec tag/pix_fmt mapping?
> > > > 
> > > > the pixel format is more or less a decoder output property
> > > > and an encoder input property
> > > > its not really a demuxer level property.
> > > 
> > > The code here tries to understand if the codec id is RAWVIDEO, is not
> > > trying to get the pixel format (that is computed in rawdec.c), but in
> > > order to do that it's using the mapping in ff_raw_pixelFormatTags.
> > > 
> > > Alternatively we could just assume RAWVIDEO by default, really can't
> > > say if that would be better.
> > 
> > as my initial reply:
> > "the codec tag/id mapping must be in AVOutputFormat.codec_tag"
> > or for demuxers in AVInputFormat.codec_tag
> 
> codec tag/id mapping also depends on the type of codec, so this can be
> done for example in the nut demuxer, also currently it is not possible
> to map codec id <-> codec type.

i dont understand you


> 
> Attached another variant.
> -- 
> FFmpeg = Faithless and Fantastic Miracolous Portentous Entertaining Genius

>  nut.c    |   33 +++++++++++++++++++++++++++++++++
>  nut.h    |    1 +
>  nutdec.c |    1 +
>  nutenc.c |    2 +-
>  4 files changed, 36 insertions(+), 1 deletion(-)
> b9da5f3dee52c9c8c053ac325af92644f0d9a5dc  0006-Define-ff_nut_video_tags-and-make-Nut-muxer-and-demu.patch
> >From a3b8b30868a09e5ab3b7564bd7a35e90ba1fa5bf Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sun, 9 May 2010 12:24:14 +0200
> Subject: [PATCH 06/11] Define ff_nut_video_tags and make Nut muxer and demuxer set it in
>  codec_tag.
> 
> This allows the muxer to use the Nut rawvideo pixel formats codec
> tags.

looks ok
[...]

>  nutdec.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> fdd7967635a3d13589dc8a0869ec1ed5d0f3dcec  0007-Make-the-nut-decoder-read-the-ff_nut_video_tags-to-d.patch
> >From b52e53e6b7763f7278e8fee898046945f7827ce4 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sat, 22 May 2010 17:12:58 +0200
> Subject: [PATCH 07/11] Make the nut decoder read the ff_nut_video_tags to detect codec id of
>  the input file.
> 
> This is required as Nut codec tags are not contained in
> ff_codec_bmp_tags.

looks ok too

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100523/a44ea40d/attachment.pgp>