[FFmpeg-devel] [PATCH] RealMedia muxer: support audio codecs other than AC-3

[Michael Niedermayer]

On Sat, May 22, 2010 at 03:50:48PM +0200, Francesco Lavra wrote:
> On Sat, 2010-05-22 at 14:24 +0200, Michael Niedermayer wrote:
> > On Sat, May 22, 2010 at 09:39:12AM +0200, Francesco Lavra wrote:
> > > On Wed, 2010-05-19 at 20:43 +0100, M?ns Rullg?rd wrote:
> > > > Francesco Lavra <francescolavra at interfree.it> writes:
> > > > 
> > > > >> > +#include "riff.h"
> > > > >> 
> > > > >> Why? Rest of patch #1 is OK.
> > > > >
> > > > > Because AVCodecTag is defined there.
> > > > 
> > > > This has bothered me for some time.  IMO we should move that struct
> > > > somewhere else.  It is in no way specific to the RIFF formats.
> > > 
> > > The attached patch moves the struct to avformat.h and changes various
> > > #includes accordingly.
> > 
> > idont think moving it from a private header to a public header is a good idea
> 
> Next try (now moved to internal.h)
> 

>  caf.c      |    2 +-
>  caf.h      |    2 +-
>  flvenc.c   |    2 +-
>  internal.h |    5 +++++
>  isom.c     |    2 +-
>  isom.h     |    2 +-
>  nut.c      |    1 +
>  nutenc.c   |    1 +
>  riff.h     |    6 +-----
>  voc.c      |    1 +
>  vocdec.c   |    1 +
>  vocenc.c   |    1 +
>  12 files changed, 16 insertions(+), 10 deletions(-)
> e47002e3d38568039d98eafbfe7c44c5e336c734  avcodectag.patch

should be ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100522/becbde00/attachment.pgp>