[FFmpeg-devel] [PATCH] RealMedia muxer: support audio codecs other than AC-3

Francesco Lavra francescolavra
Sat May 22 15:50:48 CEST 2010


On Sat, 2010-05-22 at 14:24 +0200, Michael Niedermayer wrote:
> On Sat, May 22, 2010 at 09:39:12AM +0200, Francesco Lavra wrote:
> > On Wed, 2010-05-19 at 20:43 +0100, M?ns Rullg?rd wrote:
> > > Francesco Lavra <francescolavra at interfree.it> writes:
> > > 
> > > >> > +#include "riff.h"
> > > >> 
> > > >> Why? Rest of patch #1 is OK.
> > > >
> > > > Because AVCodecTag is defined there.
> > > 
> > > This has bothered me for some time.  IMO we should move that struct
> > > somewhere else.  It is in no way specific to the RIFF formats.
> > 
> > The attached patch moves the struct to avformat.h and changes various
> > #includes accordingly.
> 
> idont think moving it from a private header to a public header is a good idea

Next try (now moved to internal.h)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: avcodectag.patch
Type: text/x-patch
Size: 4398 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100522/6e5586c9/attachment.bin>



More information about the ffmpeg-devel mailing list