[FFmpeg-devel] [PATCH] RealMedia muxer: support audio codecs other than AC-3

Michael Niedermayer michaelni
Sat May 22 14:24:29 CEST 2010


On Sat, May 22, 2010 at 09:39:12AM +0200, Francesco Lavra wrote:
> On Wed, 2010-05-19 at 20:43 +0100, M?ns Rullg?rd wrote:
> > Francesco Lavra <francescolavra at interfree.it> writes:
> > 
> > >> > +#include "riff.h"
> > >> 
> > >> Why? Rest of patch #1 is OK.
> > >
> > > Because AVCodecTag is defined there.
> > 
> > This has bothered me for some time.  IMO we should move that struct
> > somewhere else.  It is in no way specific to the RIFF formats.
> 
> The attached patch moves the struct to avformat.h and changes various
> #includes accordingly.

idont think moving it from a private header to a public header is a good idea

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100522/4a6a9114/attachment.pgp>



More information about the ffmpeg-devel mailing list