[FFmpeg-devel] [PATCH 11/13] Make nut muxer try to get the codec id from ff_raw_pixelFormatTags if ff_codec_get_id() cannot find it.

[Michael Niedermayer]

On Fri, May 21, 2010 at 01:19:06AM +0200, Stefano Sabatini wrote:
> On date Monday 2010-05-17 01:15:26 +0200, Michael Niedermayer encoded:
> > On Sat, May 15, 2010 at 04:43:31PM +0200, Stefano Sabatini wrote:
> > > On date Monday 2010-05-10 00:14:47 +0200, Michael Niedermayer encoded:
> > > > On Sun, May 09, 2010 at 04:29:29PM +0200, Stefano Sabatini wrote:
[...]

> > > > the codec tag/id mapping must be in AVOutputFormat.codec_tag
> > > 
> > > Yes but what about codec tag/pix_fmt mapping?
> > 
> > the pixel format is more or less a decoder output property
> > and an encoder input property
> > its not really a demuxer level property.
> 
> The code here tries to understand if the codec id is RAWVIDEO, is not
> trying to get the pixel format (that is computed in rawdec.c), but in
> order to do that it's using the mapping in ff_raw_pixelFormatTags.
> 
> Alternatively we could just assume RAWVIDEO by default, really can't
> say if that would be better.

as my initial reply:
"the codec tag/id mapping must be in AVOutputFormat.codec_tag"
or for demuxers in AVInputFormat.codec_tag

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100521/62f8faf1/attachment.pgp>