[FFmpeg-devel] [PATCH] implement frame buffering in vsrc buffer

[Michael Niedermayer]

On Thu, May 20, 2010 at 12:42:32PM -0700, Baptiste Coudurier wrote:
> On 05/20/2010 12:36 PM, Michael Niedermayer wrote:
>> On Thu, May 20, 2010 at 01:26:34AM -0700, Baptiste Coudurier wrote:
>>> Hi
>>>
>>> $subject.
>>
>> we have a fifo filter in soc. Is that not useable?
>
> I'm not sure. vf_fifo seems crude to me.
> Enhancing vsrc buffer is more straightforward IMHO.

i dont mind

but we must do something about the picture copy
a user application should be able to give
1. static buffers to av_vsrc_buffer_add_frame()
    That is read only buffers that must be consumed before returning
    This is not well supported as we always copy even if the frame would
    end up being used before the next frame is decoded.
    maybe a second function that is called after 
    av_vsrc_buffer_add_frame() and get_filtered_video_pic() but before
    the next avcodec_decode_video() could be added
2. frames that are fully ours and can be read and written to
   these obviously wont need to be copied
   but we need a callback to free them the way the user app needs it
3. frames that are read-only for us but that wont be reused by the
   decoder before we tell the user app that we are done with them
   as with 2. we need a callback that is called once all filters are
   done with the frame so the user app can reuse of free the buffer
2+3 are more imporant than 1, but 1 could be done without get_buffer()
changes

i know this isnt exactly a on topic coment now, iam mostly mentioning
it so we dont forget that code changes should be done with this in
mind and not end up making a copyfree filter harder later

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100520/9315744c/attachment.pgp>