[FFmpeg-devel] [PATCH] WebM mux/demux

[Ronald S. Bultje]

Hi,

On Wed, May 19, 2010 at 5:22 PM, David Conrad <lessen42 at gmail.com> wrote:
> (for certain definitions of fixed...)
[..]
> +        int probelen = strlen(matroska_doctypes[i]);
> +        for (n = 4+size; n <= 4+size+total-(probelen-1); n++)
> +            if (!memcmp(p->buf+n, matroska_doctypes[i], probelen-1))

Why -1? The original code has -1 because sizeof(str) includes the
terminating zero. strlen() doesn't count that, so the -1 becomes
unnecessary.

Otherwise yes, but Baptiste is maintainer.

Ronald