[FFmpeg-devel] [PATCH] VP8 de/encode via libvpx

[Michael Niedermayer]

On Wed, May 19, 2010 at 01:27:41PM -0700, Baptiste Coudurier wrote:
> Hi,
>
> On 05/19/2010 01:22 PM, Reimar D?ffinger wrote:
>> On Wed, May 19, 2010 at 02:56:15PM -0400, David Conrad wrote:
>>>> +  /*FIXME set based on user parameters. for now we'll disable based on
>>>> +    libpostproc presence in mplayer/ffmpeg based builds*/
>>>> +  if(flags&VPX_CODEC_USE_POSTPROC) {
>>>> +    ppcfg.post_proc_flag   = VP8_DEMACROBLOCK|VP8_DEBLOCK|VP8_ADDNOISE;
>>>> +    ppcfg.deblocking_level = 5;
>>>> +    ppcfg.noise_level      = 1;
>>>> +    vpx_codec_control(&ctx->decoder,VP8_SET_POSTPROC,&ppcfg);
>>>> +  }
>>>
>>> IMO, a decoder shouldn't do postprocessing not required by the standard 
>>> (e.g. in-loop filtering only)
>>
>> At the very least the post-processing must be significantly better than 
>> any of the generic
>> ones and it must be hard to improve the generic ones to perform similarly 
>> well.
>> Otherwise it's just a duplicate implementation that at best will confuse 
>> users as to which to use.
>
> While I agree with this, I think it is necessary to at least output the 
> same picture as the other decoders in the wild by default.

i think we should do postprocessing for mpeg1/2/4 and mjpeg by default as
well when there is enough cpu power available. And through an avfilter.
Once we have that we should check if our (libpostproc based) filter looks
better than vp8s default and if so i dont think it makes much sense to
use vp8s by default. Otherwise our filter probably should be improved
i dont mind supporting vp8s pp through a avfilter but supprting it
in such incestrously merged way in the vp8 decoder is really nasty, i hope
that it can be supported in some nicer way

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100519/5575afb9/attachment.pgp>