[FFmpeg-devel] [PATCH] VP8 de/encode via libvpx

[Reimar Döffinger]

On Wed, May 19, 2010 at 02:56:15PM -0400, David Conrad wrote:
> > +  /*FIXME set based on user parameters. for now we'll disable based on
> > +    libpostproc presence in mplayer/ffmpeg based builds*/
> > +  if(flags&VPX_CODEC_USE_POSTPROC) {
> > +    ppcfg.post_proc_flag   = VP8_DEMACROBLOCK|VP8_DEBLOCK|VP8_ADDNOISE;
> > +    ppcfg.deblocking_level = 5;
> > +    ppcfg.noise_level      = 1;
> > +    vpx_codec_control(&ctx->decoder,VP8_SET_POSTPROC,&ppcfg);
> > +  }
> 
> IMO, a decoder shouldn't do postprocessing not required by the standard (e.g. in-loop filtering only)

At the very least the post-processing must be significantly better than any of the generic
ones and it must be hard to improve the generic ones to perform similarly well.
Otherwise it's just a duplicate implementation that at best will confuse users as to which to use.