[FFmpeg-devel] [PATCH] WebM mux/demux

[Ronald S. Bultje]

Hi,

On Wed, May 19, 2010 at 3:05 PM, David Conrad <lessen42 at gmail.com> wrote:
> On May 19, 2010, at 3:02 PM, Ronald S. Bultje wrote:
>> On Wed, May 19, 2010 at 2:51 PM, James Zern <jzern at google.com> wrote:
>>> Related thread: '[PATCH] VP8 de/encode via libvpx'
>>> VP8 and associated WebM container made public today [1].
>>>
>>> The attached adds WebM de/muxing to matroska.
>>> For both some extra ifdef's/checks were added to only allow VP8/vorbis
>>> as that is the current supported configuration in web browsers. If
>>> these are too busy in this respect they be cleaned up.
>>
>> Why is the "webm demuxer" separate? Our quicktime demuxer, for
>> example, demuxes mp4 and 3gp also. The same could be done for
>> matroska. After all, it's a regular subset and thus any matroska
>> demuxer understanding the "webm" ID could demux webm files also. (I
>> know this isn't true for the muxer.)
>
> Agreed, it should be something like the attached

Almost, right now it uses sizeof(doctype), you make that strlen, which
is a little slower (don't forget you loop it many times). You could
probably calculate that once outside the loop and then use that
(static, unchangeable) value in the loop every iteration.

Other than that, yes that's what I had in mind.

Ronald