[FFmpeg-devel] [PATCH] Rename ff_random_get_seed to av_*, export the header

[Martin Storsjö]

On Sun, 16 May 2010, Michael Niedermayer wrote:

> >  ffserver.c               |    2 +-
> >  libavfilter/parseutils.c |    2 +-
> >  libavformat/httpauth.c   |    2 +-
> >  libavformat/mxfenc.c     |    2 +-
> >  libavformat/rtpenc.c     |    4 ++--
> >  libavutil/Makefile       |    1 +
> >  libavutil/random_seed.c  |   11 ++++++++++-
> >  libavutil/random_seed.h  |    2 +-
> >  8 files changed, 18 insertions(+), 8 deletions(-)
> > 1d2ada2b075c0d791fee7372045b93fc0ba4e5f4  0001-Make-ff_random_get_seed-public-by-renaming-to-av_-ex.patch
> > From d55c1e853481be06e28f6edf01bc2be7327ed301 Mon Sep 17 00:00:00 2001
> > From: Martin Storsjo <martin at martin.st>
> > Date: Fri, 14 May 2010 09:48:23 +0300
> > Subject: [PATCH] Make ff_random_get_seed public by renaming to av_*, export the header
> > 
> > Keep an old ff_ named function for binary compatibility until the
> > next major bump.
> 
> maybe the returnd value should be 64 bit instead of 32?

In most cases where it is used at the moment, we need either exactly 32 
bits, or the actual size of the seed doesn't matter at all, so given that, 
I think it's better to keep it at 32.

Any opinions on the name as Stefano pointed out? That is, 
av_random_get_seed() or av_get_random_seed(), which one do you prefer?

// Martin