[FFmpeg-devel] [PATCH] Seeking to beginning of avi file skips first audio packet

Martin Storsjö martin
Mon May 17 18:13:32 CEST 2010


On Mon, 17 May 2010, John Stebbins wrote:

> On 05/17/2010 08:45 AM, Rodney Baker wrote:
> > John,
> > FFmpeg devel policy is that cosmetics and functional changes are kept separate 
> > and submitted in separate patches. No-one is saying don't do the cosmetics, 
> > just split it into a separate patch to be applied after the functional 
> > changes. That's all. 
> >
> >   
> That's really inefficient for such a minor change.  Makes one less
> inclined to go through the trouble of submitting a 10 line patch.
> But here ya go.

It really helps speed up reviews, if one doesn't have to proof-read to see 
whether the reindented lines were changed or not. With git and normal 
diff, you can add -w to automatically create such a patch, and skip 
sending a reindent patch - the one that applies the patch probably can do 
the reindenting himself, too.

// Martin



More information about the ffmpeg-devel mailing list