[FFmpeg-devel] [PATCH] IFF: Merge lots of duplicate code into a single function
Ronald S. Bultje
rsbultje
Sun May 16 18:23:17 CEST 2010
Hi,
On Sun, May 16, 2010 at 12:06 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> Besides this, I added Stefano's hint about get_buffer returning err
> instead -1 here, since I had to introduce err variable here anyway.
[..]
> - if (avctx->reget_buffer(avctx, &s->frame) < 0){
> + if ((err = avctx->reget_buffer(avctx, &s->frame)) < 0) {
> av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
> - return -1;
> + return err;
> }
Well, that should be a separate patch, but is OK otherwise... Rest of
patch is OK also..
Ronald
More information about the ffmpeg-devel
mailing list