[FFmpeg-devel] [PATCH] IFF: Add the HAM stuff

Sebastian Vater cdgs.basty
Sun May 16 16:05:21 CEST 2010


Michael Niedermayer a ?crit :
> On Sun, May 16, 2010 at 01:03:34AM +0200, Stefano Sabatini wrote:
>   
>> On date Sunday 2010-05-16 00:40:21 +0200, Sebastian Vater encoded:
>>     
>>> Stefano Sabatini a ?crit :
>>>       
>>>>> +/**
>>>>> + * Extracts the IFF extra context and updates internal
>>>>> + * decoder structures.
>>>>> + *
>>>>> + * @param avctx the AVCodecContext where to extract extra context to
>>>>> + * @param avpkt the AVPacket to extract extra context from
>>>>> + *
>>>>>     
>>>>>           
>>>> Nit+++: no need for this empty newline
>>>>   
>>>>         
>>> Which empty new line? They're just cosmetics like in the other
>>> functions, too. So you see return value separated to args.
>>>       
>> Well it's a level 3 nit, so it's really not important if you prefer
>>     
>
> i thought nit+++ is a syntax error ;)
>   

Well, anyway, I just decided to remove the empty newlines between @param
and @return, since I've seen that lots of other documentation in FFmpeg
is handled this way, too.

So I think it's better it's consistent with the other stuff around here.

So here's a new patch fixing that, apart from this there aren't anymore
changes except some nit++ stuff which I detected today, too.

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-ham-support.patch
Type: text/x-patch
Size: 23103 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100516/5e47a618/attachment.bin>



More information about the ffmpeg-devel mailing list