[FFmpeg-devel] [PATCH] Rename ff_random_get_seed to av_*, export the header

Martin Storsjö martin
Sat May 15 16:43:51 CEST 2010


On Sat, 15 May 2010, Stefano Sabatini wrote:

> On date Friday 2010-05-14 21:13:18 +0300, Martin Storsj? encoded:
> > 
> > Ok, so like this then?
> > 
> > // Martin
> 
> > From d55c1e853481be06e28f6edf01bc2be7327ed301 Mon Sep 17 00:00:00 2001
> > From: Martin Storsjo <martin at martin.st>
> > Date: Fri, 14 May 2010 09:48:23 +0300
> > Subject: [PATCH] Make ff_random_get_seed public by renaming to av_*, export the header
> > 
> > Keep an old ff_ named function for binary compatibility until the
> > next major bump.
> > ---
> >  ffserver.c               |    2 +-
> >  libavfilter/parseutils.c |    2 +-
> >  libavformat/httpauth.c   |    2 +-
> >  libavformat/mxfenc.c     |    2 +-
> >  libavformat/rtpenc.c     |    4 ++--
> >  libavutil/Makefile       |    1 +
> >  libavutil/random_seed.c  |   11 ++++++++++-
> >  libavutil/random_seed.h  |    2 +-
> >  8 files changed, 18 insertions(+), 8 deletions(-)
> 
> What about av_get_random_seed()?, it sounds better than
> av_random_get_seed().

What do other people think about the naming? I'll wait for at least a few 
more comments before I do anything.

> Apart from this, Looks fine to me, don't forget to bump lavu minor
> when committing and add an entry to APIchanges in a separate commit.

Will do, when people agree on the naming.

// Martin



More information about the ffmpeg-devel mailing list