[FFmpeg-devel] [PATCH 10/13] Add rawvideo pixel formats to codec tags mapping for the newly added nut rawvideo pixel formats codec tags.

[Michael Niedermayer]

On Fri, May 14, 2010 at 02:09:23AM +0200, Stefano Sabatini wrote:
> On date Thursday 2010-05-13 21:11:05 +0200, Michael Niedermayer encoded:
> > On Thu, May 13, 2010 at 12:29:17AM +0200, Stefano Sabatini wrote:
> > > On date Wednesday 2010-05-12 02:26:14 +0200, Michael Niedermayer encoded:
> > > > On Wed, May 12, 2010 at 01:31:26AM +0200, Stefano Sabatini wrote:
> > > > > On date Sunday 2010-05-09 23:18:47 +0200, Michael Niedermayer encoded:
> > > > > > On Sun, May 09, 2010 at 03:33:27PM +0200, Stefano Sabatini wrote:
> > > > > [...]
> > > > > > >  nut4cc.txt |   10 ++++++++++
> > > > > > >  1 file changed, 10 insertions(+)
> > > > > > > 4ad3cc6b63e9431047b26f2965899ae6c9b8cefe  nut4cc-additions.patch
> > > > > > > Index: docs/nut4cc.txt
> > > > > > > ===================================================================
> > > > > > > --- docs/nut4cc.txt	(revision 666)
> > > > > > > +++ docs/nut4cc.txt	(working copy)
> > > > > > > @@ -91,6 +91,16 @@
> > > > > > >  ARGB    Packed RGBA 8:8:8:8, 32bpp, ARGB [NOT in AVI]
> > > > > > >  RGB[24] Packed RGB 8:8:8, 24bpp RGB [NOT in AVI]
> > > > > > >  BGR[24] Packed RGB 8:8:8, 24bpp BGR [NOT in AVI]
> > > > > > > +MOWH    1bpp, 0 is white, 1 is black [NOT in AVI]
> > > > > > > +MOBL    1bpp, 0 is black, 1 is white [NOT in AVI]
> > > > > > 
> > > > > > these appear fliped from what i would have expected
> > > > > 
> > > > > This is misleading but correct.
> > > > 
> > > > in ffmpeg yes, in nut its undefined and we can define it as we prefer
> > > > and i dont like knowingly adding something we consider misleading
> > > 
> > > OK have a look at my idea, I don't want to use anymore the terms
> > > monowhite/monoblack with a different meaning from that of pixfmt.h, to
> > > avoid confusion to the FFmpeg user.
> > 
> > this part looks ok
> > 
> > 
> > >  
> > > > > > > +BGR[8]  Packed RGB 3:3:2,  8bpp, (msb)2B 3G 3R(lsb) [NOT in AVI]
> > > > > > > +RGB[8]  Packed RGB 3:3:2,  8bpp, (msb)2B 3G 3R(lsb) [NOT in AVI]
> > > > > >                                          ^^^^^^^^
> > > > > > copy and paste error
> > > > > 
> > > > > Fixed.
> > > > >  
> > > > > > > +BGR[4]  Packed RGB 1:2:1,  4bpp, (msb)1B 2G 1R(lsb) [NOT in AVI]
> > > > > > > +RGB[4]  Packed RGB 1:2:1,  4bpp, (msb)1B 2G 1R(lsb) [NOT in AVI]
> > > > > > 
> > > > > > ambigous, (the placeent of pixels in a byte)
> > > > > 
> > > > > This is a bitstream format, clarified.
> > > > 
> > > > bitstream doesnt clarify it
> > > > the msb or the lsb can be first in a byte in a bitstream
> > > 
> > > No I cannot get this, please elaborate.
> > 
> > assume you have 4 4 bit values
> > 16 15 1 2
> > 
> > this can correspond to bitstreams of
> > 10001111 00010010
> > or
> > 11111000 00100001
> 
> Thanks, tried my best at rendering this explanation using my clunky
> English.
> 
> Regards.
> -- 
> FFmpeg = Freak and Fierce Magnificient Powerful Erroneous Genius

>  pixfmt.h |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> b291d78639caa12515a1e1720c48b4e83dca9870  0001-Clarify-descriptions-for-RGB4-BGR4-NV12-NV21.patch
> >From ff69d6c888de0f4272bd6e732f3969535b5d6d97 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Wed, 12 May 2010 01:20:14 +0200
> Subject: [PATCH 1/8] Clarify descriptions for RGB4, BGR4, NV12, NV21,
>  RGB48BE, and RGB48LE pixel formats.

ok


[...]

>  nut4cc.txt |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> a70981c1c057d16f5fa3bcdca57f39e8c2f19106  extend-nut-fourcc-tags.patch
> Index: docs/nut4cc.txt
> ===================================================================
> --- docs/nut4cc.txt	(revision 666)
> +++ docs/nut4cc.txt	(working copy)
> @@ -91,6 +91,16 @@
>  ARGB    Packed RGBA 8:8:8:8, 32bpp, ARGB [NOT in AVI]
>  RGB[24] Packed RGB 8:8:8, 24bpp RGB [NOT in AVI]
>  BGR[24] Packed RGB 8:8:8, 24bpp BGR [NOT in AVI]
> +B1W0    black/white bitstream, 1bpp, 0 is white, 1 is black [NOT in AVI]
> +B0W1    black/white bitstream, 1bpp, 1 is white, 0 is black [NOT in AVI]

here too the ordering in a byte is ambigous


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100514/7e960614/attachment.pgp>