[FFmpeg-devel] [PATCH] IFF: Make ff_cmap_read_palette static, remove ff_ prefix

[Michael Niedermayer]

On Thu, May 13, 2010 at 10:04:25PM +0200, Sebastian Vater wrote:
> Reinhard Tartler a ?crit :
> > On Thu, May 13, 2010 at 16:20:14 (CEST), Ronald S. Bultje wrote:
> >
> >   
> >> Hi,
> >>
> >> On Sun, May 9, 2010 at 2:32 PM, Martin Storsj? <martin at martin.st> wrote:
> >>     
> >>> I'll move the question to Reinhard here. For distros shipping shared
> >>> libraries of lavc/lavf where versions can be mixed potentially, would we
> >>> be required to keep a ff_cmap_palette_static function with unchanged
> >>> behaviour, for compatibility with older lavf versions which still
> >>> reference it?
> >>>       
> >> Distro-makers, ping. Otherwise I apply this and break your build and
> >> it's your own fault.
> >>     
> >
> >
> > For this specific case, I'd really appreciate if we could keep a dummy
> > function to ensure that the old libavcodec remains functional. Otherwise
> > I'd have to introduce such a function in a release branch or at least as
> > a as distro patch.
> >   
> 
> Ok, I did a patch for this. I also added comment in the header file
> which warns that this function is deprecated.

i think the function should be under something like
#if LIBAVCODEC_VERSION < next major bump vers

so we dont forget to drop it with the next major bump

[..]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100514/8f494bac/attachment.pgp>