[FFmpeg-devel] [PATCH] IFF: Make ff_cmap_read_palette static, remove ff_ prefix

[Reinhard Tartler]

On Thu, May 13, 2010 at 16:20:14 (CEST), Ronald S. Bultje wrote:

> Hi,
>
> On Sun, May 9, 2010 at 2:32 PM, Martin Storsj? <martin at martin.st> wrote:
>> On Sun, 9 May 2010, Sebastian Vater wrote:
>>> After removal of ff_cmap_read_palette in libavfilter/iff.c, it's now
>>> time to make ff_cmap_palette_static static and remove the ff_ prefix.
>>
>> I'll move the question to Reinhard here. For distros shipping shared
>> libraries of lavc/lavf where versions can be mixed potentially, would we
>> be required to keep a ff_cmap_palette_static function with unchanged
>> behaviour, for compatibility with older lavf versions which still
>> reference it?
>
> Distro-makers, ping. Otherwise I apply this and break your build and
> it's your own fault.

Okay, so this will bite in the case that the soname of libavcodec is
bumped but not libavformat's. In that case the old libavcodec will not
work with the newer libavformat. Such a setting is possible during the
transition period to a newer ffmpeg release. It would be a non-issue if
the soname of both libavcodec and libavformat would be bumped at the
same time. But I don't think we can count on that.

For this specific case, I'd really appreciate if we could keep a dummy
function to ensure that the old libavcodec remains functional. Otherwise
I'd have to introduce such a function in a release branch or at least as
a as distro patch.


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4