[FFmpeg-devel] [PATCH] fix tools/probetest compilation

[Michael Niedermayer]

On Thu, May 13, 2010 at 05:36:24PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Thu, May 13, 2010 at 04:47:47PM +0100, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> 
> >> > On Thu, May 13, 2010 at 01:42:44AM +0200, Janne Grunau wrote:
> >> >> Hi,
> >> >> 
> >> >> tools/probetest uses internal functions and need -DHAVE_AV_CONFIG_H to
> >> >> compile. see patch.
> >> >
> >> > i think it worked without that in the past. Find which commit broke
> >> > it please and then lets fix or revert that
> >> 
> >> It broke when we stopped passing that flag.
> >> 
> >> > its very very bad if tools use internal API, as people will use it
> >> > as example for their applications
> >> 
> >> Then perhaps you'd like to fix them.
> >
> > done
> 
> At the cost of breaking the build entirely with some compilers.

if so i will try my best to fix it and if i fail we can still revert.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100513/2c805e68/attachment.pgp>