[FFmpeg-devel] [PATCH] IFF: Check for invalid width and height in decoder

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Mon, May 10, 2010 at 01:22:08AM +0200, Sebastian Vater wrote:
>> Stefano Sabatini a ?crit :
>> > width *or* height, also it's always nice to show the actual invalid
>> > values, check how avcodec_check_dimensions() does it.
>> >   
>> 
>> Fixed by copying message from avcodec_check_dimensions!
>> 
>> I have ignored the upper bound checks because they can't apply (they're
>> uint16_t in IFF-ILBM).
>> 
>> -- 
>> 
>> Best regards,
>>                    :-) Basty/CDGS (-:
>> 
>
>>  iff.c |    4 ++++
>>  1 file changed, 4 insertions(+)
>> 3db8467b2aebea4df8b7c9fa6e37ce570dbae3e4  iff-decoder-width-height-check.patch
>
> ok with me, that is if noone minds printing signed values  with %u

I mind.  The code is checking for negative size, but prints the
offending values as unsigned.  WTF?

-- 
M?ns Rullg?rd
mans at mansr.com