[FFmpeg-devel] [PATCH] HAM6/HAM8 support for IFF demuxer/decoder

[Sebastian Vater]

Stefano Sabatini a ?crit :
> On date Sunday 2010-05-09 18:17:50 +0200, Sebastian Vater encoded:
>   
>> Stefano Sabatini a ?crit :
>>     
>>> On date Thursday 2010-05-06 23:23:20 +0200, Sebastian Vater encoded:
>>>   
>>>       
>>>> Sebastian Vater a ?crit :
>>>>     
>>>>  /**
>>>>   * Convert CMAP buffer (stored in extradata) to lavc palette format
>>>>   */
>>>> -int ff_cmap_read_palette(AVCodecContext *avctx, uint32_t *pal)
>>>> +static int cmap_read_palette(AVCodecContext *avctx, uint32_t *pal)
>>>>     
>>>>         
>>> This looks fine, but this change deserves a separate patch.
>>>   
>>>       
>> Why? It's important to change this with HAM support, the old code
>> doesn't really have any problems with it.
>>     
>
> Looks orthogonal to the current change, you could just keep it
> non static with the new code too, right? So I don't see why it is
> required by *this* change (but I may have missed something from the
> previous discussion).
>   

In fact, HAM requires it, but just look the new thread I opened, I
attached a patch there which does this alone...

>  
> Yes a macro should be fine. 
>   

Is it enough to just create a macro for byterun decoding?

> Nit++: an empty line before @params helps readability.
>   

Fixed, but won't submit a new patch for this immediately.

> Could you explain these last two chunks? I see no obvious correlation
> with the rest of the patch.
>
> Regards.
>   

Just see above, I put them in a separate patch.

-- 

Best regards,
                   :-) Basty/CDGS (-: