[FFmpeg-devel] [PATCH] HAM6/HAM8 support for IFF demuxer/decoder

[Sebastian Vater]

Martin Storsj? a ?crit :
> On Sun, 9 May 2010, Sebastian Vater wrote:
>
>   
>> It is, simply because it is strictly illegal now to call
>> cmap_read_palette starting with this patch.
>>     
>
> Illegal for which parts - you still call it from within libavcodec/iff.c. 
> I assume you meant that it's illegal to call it from outside of 
> lavc/iff.c, right?
>   

Yes, of course! ;-)

>   
>> The thing is when I keep the function as is, I have to keep the
>> prototype declaration also in the header file.
>>
>> But that is dangerous, because people could think that it's still legal
>> to use it with this patch, but it isn't anymore!
>> Or may I move the iff.h declaration of ff_cmap_read_palette in
>> libavcodec/iff.c?
>>     
>
> Ok, given that you change how the function behaves, removing it all at 
> once could be warranted. But if you're afraid someone would use it, you 
> could still make it static and remove it from iff.h in a separate patch 
> which is applied immediately afterwards, leaving the window of someone 
> "thinking it's legal" to the time between two successive commits.
>
> So I guess either way is acceptable in this case.
>   

I would then prefer the way of my last reply to "myself", i.e. doing the
rename/static at first and create the HAM patch based on this, this will
ensure that it can only be applied if the function is static.

-- 

Best regards,
                   :-) Basty/CDGS (-: