[FFmpeg-devel] [PATCH] HAM6/HAM8 support for IFF demuxer/decoder

[Sebastian Vater]

Sebastian Vater a ?crit :
> Martin Storsj? a ?crit :
>   
>> No, it is not important for this change. In this patch, you remove usage 
>> of ff_cmap_read_palette from libavformat/iff.c. You don't _need_ to change 
>> this now. The code will work just as well without changing this.
>>   
>>     
>
> It is, simply because it is strictly illegal now to call
> cmap_read_palette starting with this patch.
> The thing is when I keep the function as is, I have to keep the
> prototype declaration also in the header file.
>
> But that is dangerous, because people could think that it's still legal
> to use it with this patch, but it isn't anymore!
> Or may I move the iff.h declaration of ff_cmap_read_palette in
> libavcodec/iff.c?
>   

The other possibility would be, though that I just do an extra patch
which removes it from libavfilter alone and on the same hand rename the
function and make it static and then create the HAM patch based on this.

Is this better?

-- 

Best regards,
                   :-) Basty/CDGS (-: