[FFmpeg-devel] [PATCH] HAM6/HAM8 support for IFF demuxer/decoder

[Ronald S. Bultje]

Hi,

On Thu, May 6, 2010 at 1:48 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> Hope patch is fine now. :)

(Just noting that it decreased more than 1kB in size already, that's good!)

> +    const uint8_t *ex = GET_EXTRA_CONTEXT(avctx);
>     int err;
>
> -    if (avctx->bits_per_coded_sample <= 8) {
> -        avctx->pix_fmt = PIX_FMT_PAL8;
> +    if (ex) {

Ah, there you go again. ex = ctx->extradata;
if (ctx->extradata_size > ...) {

Same amount of code, less instructions executed, and the macros are no
longer needed = smaller patch.

> +#define EXTRA_CONTEXT_COMPRESSION   0

All those are unused. I'd recommend replacing it all by a 2-3 line
doxy explaining the extradata layout.

Ronald