[FFmpeg-devel] use of UINT64_C in libavutil/common.h

Ronald S. Bultje rsbultje
Thu May 6 17:11:53 CEST 2010


Hi,

On Thu, May 6, 2010 at 11:02 AM, VALETTE Eric RD-MAPS-REN
<eric2.valette at orange-ftgroup.com> wrote:
> On 05/06/2010 04:54 PM, Ronald S. Bultje wrote:
>> On Thu, May 6, 2010 at 10:52 AM, VALETTE Eric RD-MAPS-REN
>> <eric2.valette at orange-ftgroup.com> ?wrote:
>>> Before the commit mentioned in another post it was not a problem. Now it
>>> is.
>>
>> I'm OK with a patch that changes the UINT64_C() into something else that
>> is:
>> A) binary compatible
>> B) same amount of code
>
> The simplest thing is to test if the macros is defined and if not redefine
> it one way or other to always get a definition. Reincluding the stdint.h
> with the correct define like I proposed may be an overkill but I dislike
> redefining something defined elsewhere.

The patch as posted is bigger than the current code and thus rejected,
as per rule B.

Ronald



More information about the ffmpeg-devel mailing list