[FFmpeg-devel] use of UINT64_C in libavutil/common.h

[VALETTE Eric RD-MAPS-REN]

On 05/06/2010 02:59 PM, Luca Barbato wrote:
> On 05/06/2010 11:00 AM, VALETTE Eric RD-MAPS-REN wrote:
>    
>> On 05/06/2010 10:55 AM, Luca Barbato wrote:
>>      
>>> On 05/05/2010 01:18 PM, VALETTE Eric RD-MAPS-REN wrote:
>>>
>>>        
>>>> This define is defined in<stdint.h>   The simple include<stdint.h>
>>>> should either be replaced by:
>>>>
>>>>          
>>> you might add -D__STDC_CONSTANT_MACROS to your CXXFLAGS
>>>
>>>        
>> Doing that you push the burden on all the client of the file which I
>> personally find bad practice.
>>      
> C++ isn't the ffmpeg language...
>    
Sure but some important programs using it are written in C++ and use the 
ffmpeg includes via the "extern C" trick.
Never mind, I have modified the file to be sure the macro is always 
defined (compying the stdint code) and do not have to modified a bunch 
of independently generated Makefiles by hand.

At least I have tried to make sure the impact of the modification for 
C++ program linked with libav* has been considered as the problem only 
surfaced due to recent commit

See 
<http://git.ffmpeg.org/?p=ffmpeg;a=blobdiff;f=libavutil/common.h;h=dd1c22396e83b6c1743f4884795ad9ec3cd0bb79;hp=8d7cc10012390c412eb5bef1bb0f1fdec1811ae4;hb=346f2bc2656e7f23b7fbf14563c017b49108d888;hpb=ef3268b60642de8fe34b6f8926d82ae2ef364c2b>

--eric