[FFmpeg-devel] [PATCH] Add VorbisComment writing to ogg-vorbis files (bump)

[Michael Niedermayer]

On Wed, May 05, 2010 at 01:30:58AM +0200, James Darnley wrote:
> On 5 May 2010 01:23, Baptiste Coudurier <baptiste.coudurier at gmail.com> wrote:
> > On 04/18/2010 03:47 AM, James Darnley wrote:
> >>
> >> On 8 April 2010 15:39, James Darnley<james.darnley at gmail.com> ?wrote:
> >>>
> >>> On 31 March 2010 00:35, James Darnley<james.darnley at gmail.com> ?wrote:
> >>>>>
> >>>>> As the subject says, the attached patch adds VorbisComment writing to
> >>>>> ogg-vorbis files.
> >>>>
> >>>> Perhaps more explaination will garner some attention.
> >>>>
> >>>> The change to ogg_write_vorbiscomment() is because vorbis requires
> >>>> VorbisComments to have the framing bit whereas flac and speex (based
> >>>> on inspection of a file made by speexenc) do not.
> >>>>
> >>>> Any other comments about the way I've done stuff?
> >>>>
> >>>
> >>> New patch attached. ?Changed due to the recent AVERROR() changes. ?A
> >>> couple of minor cosmetic changes too.
> >>>
> >>
> >> bump... ?does nobody want this?
> >
> > It would help review it the attachement had a better mime type.
> > There is an extra space after framing_bit and before the ')'.
> >
> > How is vorbis different from theora ? Also it seems that all codecs can
> > write a vorbiscomment so the code should be factorized.
> >
> 
> I can't help the mime type google gives it.  It's a standard text file
> with unix line endings.

i dont know about google but
with mutt on the recv side there is mime_lookup to make ignore common nonsense
mime types
... yes just thought that hint could be helpfull in this thread

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100505/bc7eda26/attachment.pgp>