[FFmpeg-devel] [PATCH] Add VorbisComment writing to ogg-vorbis files (bump)

[James Darnley]

On 5 May 2010 01:39, Stefano Sabatini <stefano.sabatini-lala at poste.it> wrote:
>> From 88c4365f9665cbc5bf57133d3feb159669b973fc Mon Sep 17 00:00:00 2001
>> From: James Darnley <james.darnley at gmail.com>
>> Date: Thu, 8 Apr 2010 15:19:23 +0200
>> Subject: [PATCH] Add VorbisComment writing to ogg-vorbis files
>>
>> ---
>> ?libavformat/oggenc.c | ? 41 +++++++++++++++++++++++++++++++++++++----
>> ?1 files changed, 37 insertions(+), 4 deletions(-)
> [...]
>> +static int ogg_build_vorbis_headers(AVCodecContext *avctx,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?OGGStreamContext *oggstream, int bitexact,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?AVMetadata *m)
>> +{
>> + ? ?int ret;
>> + ? ?uint8_t *p;
>> +
>> + ? ?ret = ff_split_xiph_headers(avctx->extradata, avctx->extradata_size,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?30, oggstream->header, oggstream->header_len);
>> + ? ?if (ret)
>> + ? ? ? ?return -1;
>
> return ret;
>

Done

>> @@ -214,6 +238,15 @@ static int ogg_write_header(AVFormatContext *s)
>> ? ? ? ? ? ? ? ? ?av_freep(&st->priv_data);
>> ? ? ? ? ? ? ? ? ?return err;
>> ? ? ? ? ? ? ?}
>> + ? ? ? ?} else if (st->codec->codec_id == CODEC_ID_VORBIS) {
>> + ? ? ? ? ? ?int err = ogg_build_vorbis_headers(st->codec, oggstream,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?st->codec->flags & CODEC_FLAG_BITEXACT,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?s->metadata);
>
> weird align.
>

How should the align for this look?  I've changed the second line so
it starts 4 spaces in from the "ogg_"