[FFmpeg-devel] [PATCH] Add VorbisComment writing to ogg-vorbis files (bump)

[Baptiste Coudurier]

On 04/18/2010 03:47 AM, James Darnley wrote:
> On 8 April 2010 15:39, James Darnley<james.darnley at gmail.com>  wrote:
>> On 31 March 2010 00:35, James Darnley<james.darnley at gmail.com>  wrote:
>>>> As the subject says, the attached patch adds VorbisComment writing to ogg-vorbis files.
>>>
>>> Perhaps more explaination will garner some attention.
>>>
>>> The change to ogg_write_vorbiscomment() is because vorbis requires
>>> VorbisComments to have the framing bit whereas flac and speex (based
>>> on inspection of a file made by speexenc) do not.
>>>
>>> Any other comments about the way I've done stuff?
>>>
>>
>> New patch attached.  Changed due to the recent AVERROR() changes.  A
>> couple of minor cosmetic changes too.
>>
>
> bump...  does nobody want this?

It would help review it the attachement had a better mime type.
There is an extra space after framing_bit and before the ')'.

How is vorbis different from theora ? Also it seems that all codecs can 
write a vorbiscomment so the code should be factorized.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org