[FFmpeg-devel] [PATCH] Fix non-rounding up to next 16-bit aligned bug in IFF decoder

Michael Niedermayer michaelni
Mon May 3 16:26:46 CEST 2010


On Mon, May 03, 2010 at 02:37:59PM +0100, M?ns Rullg?rd wrote:
> Sebastian Vater <cdgs.basty at googlemail.com> writes:
> 
> > M?ns Rullg?rd a ?crit :
> >> Sebastian Vater <cdgs.basty at googlemail.com> writes:
> >>
> >> Would you like an account on a PPC machine?
> >>   
> >
> > Yes, that would really be nice...so I can test it straight away on be.
> >
> > Thank you very much in advance!
> 
> Send me your ssh public key and desired username.
> 
> >>> Little endian was tested by me, so it works now for both...if someone
> >>> could help me shortening the #define stuff here for the 8-bit table,
> >>> I'ld be glad.
> >>>     
> >>
> >> I will, when you send a patch that applies to current svn.
> >>   
> >
> > Thanks again, so here you have your desired patch.
> >
> > But why you didn't just apply the iff-decoder-fix.patch and then the
> > iff-decoder-fix-heavy-dp8.patch?
> 
> I didn't know what I had to apply or in what order.
> 
> > Or should I integrate that decoder fix (word alignment) into this patch?
> 
> No.
> 
> Anyway, here's a cleaner table generation.  This gives the same output
> as your patch, which is different from the unpatched svn.  I've lost
> track of all the different bugs...
> 
> -- 
> M?ns Rullg?rd
> mans at mansr.com

>  iff.c |   59 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 52 insertions(+), 7 deletions(-)
> 0f1a0077463f655e9999e7ded425b01a8b13a861  mutt3ONCnu

looks ok if tested and no objections from others

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100503/307c8c89/attachment.pgp>



More information about the ffmpeg-devel mailing list