[FFmpeg-devel] [PATCH] RealMedia muxer: support audio codecs other than AC-3

[Francesco Lavra]

On Sun, 2010-05-02 at 14:30 +0300, Kostya wrote:
> On Sun, May 02, 2010 at 01:10:51PM +0200, Francesco Lavra wrote:
> > Hi,
> > currently the only audio codec supported by the RealMedia muxer is AC-3.
> > This patch series allows muxing audio streams other than AC-3. It works
> > at least with the RealAudio 14.4 codec.
> > The first and second patches contain simple code refactoring, which is
> > used in the third patch (where support for other codecs is actually
> > added); lastly, the fourth patch contains cosmetic indentation changes.
> 
> Well, having lavf RM muxer support many audio codecs is a good idea,
> here are a few comments on your patches.
> 
> Patch 1 will not be accepted until you can prove it's not slower that
> way.

The resulting code is actually slower, so patch dropped.

> Making taglist public requires adding "ff_" prefix to its name.

Fixed (now patch #1).

> The last patch looks quite fine but I'll leave it to Ronald who's also
> quite busy but at least he has means to test it.

Updated patches attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_rm.patch
Type: text/x-patch
Size: 3499 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100502/393f3627/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_rm.patch
Type: text/x-patch
Size: 1345 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100502/393f3627/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03_rm.patch
Type: text/x-patch
Size: 1129 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100502/393f3627/attachment-0002.bin>