[FFmpeg-devel] [PATCH] qt-faststart: Remove unnecessary checks before calling free

Martin Storsjö martin
Sat May 1 23:03:21 CEST 2010


On Sat, 1 May 2010, M?ns Rullg?rd wrote:

> Martin Storsj? <martin at martin.st> writes:
> 
> > On Fri, 30 Apr 2010, Frank Barchard wrote:
> >
> >> On Fri, Apr 30, 2010 at 11:16 AM, Baptiste Coudurier <
> >> baptiste.coudurier at gmail.com> wrote:
> >> 
> >> > On 04/30/2010 03:39 AM, Martin Storsj? wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> $subj
> >> >>
> >> >>
> >> > Well I'd be ok, but I thought there were some systems that would
> >> > not handle free(NULL) out there.
> >> 
> >> 
> >> Agreed.
> >
> > Hmm, ok. Out of curiosity, what systems do we support where free(NULL) 
> > isn't ok?
> 
> None.  I have never seen such a system.  They are a myth perpetrated
> by people who like justifying extraneous if statements.

Ok, applied with this reasoning. Feel free to revert the commit if you can 
point out a case where it's actually necessary.

// Martin



More information about the ffmpeg-devel mailing list