[FFmpeg-devel] [PATCH] mxfdec: make it work with other calling conventions

[Baptiste Coudurier]

On 06/30/2010 02:38 PM, Reimar D?ffinger wrote:
> On Wed, Jun 30, 2010 at 02:07:38PM -0700, Baptiste Coudurier wrote:
>> Also a few functions do not use all the parameters, when using func
>> pointers, it will cause warnings (unused arguments), with
>> unspecified prototype, it won't.
>
> ??? Unused argument warnings don't depend on how you call a function,
> at least I have never seen a compiler where this is the case.

If you declare the prototype, all functions need to use that prototype.

>> But that's more an explanation of
>> why there isn't any prototype for the read() function.
>
> I expected that is because pointers to functions with a different
> number of arguments were stored there, but that is more of an argument
> _for_ making it an error, since this allowed the fact that the
> code would crash with stdcall and all other calle-restores-stack calling
> conventions to go by unnoticed, without even a warning.

All the functions are called with the same number of arguments, there is 
only one call that uses the function pointer.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org