[FFmpeg-devel] [PATCH] mxfdec: make it work with other calling conventions

[Baptiste Coudurier]

On 06/30/2010 01:54 PM, Reimar D?ffinger wrote:
> On Wed, Jun 30, 2010 at 01:42:56PM -0700, Baptiste Coudurier wrote:
>> Will see if any compiler decide to fail in the future.
>> For now, none decided to fail.
>
> Failing at runtime is hardly better.

I'm not saying it is.

>> I'm against adding that flag, and until the majority of developpers
>> approves, it won't be added.
>
> Do we really have to vote on that?
> And if we do, how about a few arguments, you haven't said _why_ you are
> against while I think we have mentioned a few rather good reasons to?
> And either call or stop this flaming (everyone), it's really ridiculous today.

Well, first, I don't see a need to be more strict than the compiler, if 
the latter doesn't even warn about it.

Also a few functions do not use all the parameters, when using func 
pointers, it will cause warnings (unused arguments), with unspecified 
prototype, it won't. But that's more an explanation of why there isn't 
any prototype for the read() function.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org