[FFmpeg-devel] [PATCH 19/28] changed: check some more url_fseeks in asf demuxer to avoid problems if file system is unseekable

[Måns Rullgård]

Joakim Plate <elupus at ecce.se> writes:

> Reimar D?ffinger <Reimar.Doeffinger <at> gmx.de> writes:
>
>> 
>> Subject: [FFmpeg-devel] [PATCH 19/28] changed: check some more
>>         url_fseeks in
>>         asf demuxer to avoid problems if file system is unseekable
>> 
>> While probably a good idea in principle, this is the wrong solution
>> for the problem in the subject: is_streamed should be set correctly
>> instead.
>> 
>
> Which you can't know unless you try on http for example. Or the
> file may have been cut in half for some odd reason, so the point
> you seek to is not available.
>
> If the point is not available, lavf should not keep on going as
> if it succeded in seeking to that point and just read garbage.
>
> So i really really thing all attempts to seek should be checked,
> and bail out in some controlled manner. It may be possible to
> continue in some other fashion.

Anything that can fail should of course be checked.  Seeks can
certainly fail for a variety of reasons.

-- 
M?ns Rullg?rd
mans at mansr.com