[FFmpeg-devel] [PATCH] mxfdec: make it work with other calling conventions

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Tue, Jun 29, 2010 at 11:36:50PM +0100, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> [...]
>> >> >+#define METADATA_READ_FUNC(name) int name(void *arg, ByteIOContext *pb, int tag, int size, UID uid)
>> >> 
>> >> I don't like the #define.
>> >
>> > Well, the alternative is having to change every single read function
>> > manually in case you'd ever need an additional parameter.
>> > And I found it very hard to find them.
>> 
>> I'm with Reimar on this one.  
>
>> If you don't like it, fix it in some
>> other way, but don't just say no.
>
> so we can finally export libavutil/intreadwrite.h

No, because it depends on compiler-specific settings in config.h.
Without that information, it will be reduced to reading bytes at a
time and shifting.

> you know people do alraedy use it, it is de facto a public header

It is not.  What those people are doing is tying a noose around their
own necks.

> or do you need more time for supporting this another way?

There is no other way.

Now please stop trolling.  This thread is about FIXING A BUG in
mxfdec.  Not installing some header is not a bug.  Stop comparing
apples and oranges.

-- 
M?ns Rullg?rd
mans at mansr.com