[FFmpeg-devel] [PATCH] mxfdec: make it work with other calling conventions

[Måns Rullgård]

Baptiste Coudurier <baptiste.coudurier at gmail.com> writes:

> On 6/29/10 3:36 PM, M?ns Rullg?rd wrote:
>> Reimar D?ffinger<Reimar.Doeffinger at gmx.de>  writes:
>>
>>> On Tue, Jun 29, 2010 at 01:02:05PM -0700, Baptiste Coudurier wrote:
>>>> On 6/29/10 11:51 AM, Reimar D?ffinger wrote:
>>>>> On Tue, Jun 29, 2010 at 08:30:01PM +0200, Reimar D?ffinger wrote:
>>>>>> Hello,
>>>>>> currently mxfdec assumes that it can unpunished pass more arguments to functions
>>>>>> than they were declared with.
>>>>>> This is not true in general, in particular not for stdcall.
>>>>>> While I am not aware of any FFmpeg platform using it, IMHO this code is still
>>>>>> wrong.
>>>>>> Attached is a patch that fixes it, and I think it is not particularly bad.
>>>>>> It also fixes the last remaining warnings ("function declaration is not a prototype")
>>>>>> in that file.
>>>>
>>>> I don't have this warning.
>>>> gcc version 4.4.4 (Ubuntu 4.4.4-6ubuntu2)
>>>
>>> Right, I had been using -Wstrict-prototypes
>>
>> Once this is fixed I'll make that an error.  We don't want this
>> happening again.
>
> I'm against making that an error.

Functions without prototypes are an awful thing.  THEY MAKE THINGS
BREAK in ways very hard to diagnose.  Prototypes were invented for
a good reason.

-- 
M?ns Rullg?rd
mans at mansr.com