[FFmpeg-devel] [PATCH] strict-aliasing-safe aes.c

[Michael Niedermayer]

On Tue, Jun 29, 2010 at 07:27:44PM +0200, Reimar D?ffinger wrote:
> On Tue, Jun 29, 2010 at 06:16:03PM +0200, Reimar D?ffinger wrote:
> > On Tue, Jun 29, 2010 at 05:10:09PM +0100, M?ns Rullg?rd wrote:
> > > Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > > >> Are these API changes necessary?  Can't the rest of the fixes be done
> > > >> without this?
> > > >
> > > > No, they are not necessary, however I am in favour of at least having
> > > > av_aes_block available to allow for easy allocation of data
> > > > with suitable alignment.
> > > 
> > > Exposing internals like that is less than ideal.  Simply documenting
> > > the 8-byte alignment requirement should be enough.
> > 
> > I guess I agree, I'll make the change if the idea is ok'd in principle.
> 
> Oh well, I did it anyway already since I noticed I broke the more-than-one
> block case.

>  aes.c |   74 +++++++++++++++++++++++++++++++++++++-----------------------------
>  1 file changed, 42 insertions(+), 32 deletions(-)
> 172e32357bec3f033440078a57b908ff696472d7  aesalias.diff

if its confirmed that there is no speedloss and the object file does not
become larger than i wont object to the patch. But its still ugly


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100629/46035d64/attachment.pgp>