[FFmpeg-devel] [PATCH] strict-aliasing-safe aes.c

[Reimar Döffinger]

On Tue, Jun 29, 2010 at 06:16:03PM +0200, Reimar D?ffinger wrote:
> On Tue, Jun 29, 2010 at 05:10:09PM +0100, M?ns Rullg?rd wrote:
> > Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > >> Are these API changes necessary?  Can't the rest of the fixes be done
> > >> without this?
> > >
> > > No, they are not necessary, however I am in favour of at least having
> > > av_aes_block available to allow for easy allocation of data
> > > with suitable alignment.
> > 
> > Exposing internals like that is less than ideal.  Simply documenting
> > the 8-byte alignment requirement should be enough.
> 
> I guess I agree, I'll make the change if the idea is ok'd in principle.

Oh well, I did it anyway already since I noticed I broke the more-than-one
block case.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: aesalias.diff
Type: text/x-diff
Size: 6352 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100629/8e20fecc/attachment.diff>