[FFmpeg-devel] [PATCH] restoring binary compatibility with ffmpeg 0.5

[Frank Barchard]

On Mon, Jun 28, 2010 at 3:35 PM, M?ns Rullg?rd <mans at mansr.com> wrote:

> Frank Barchard <fbarchard at google.com> writes:
>
> > This patch breaks chromium linux builds, which use gyp to build ffmpeg.
>
> WTF is gyp and why do you use it to build ffmpeg?

Whatever the answer, this is the wrong place to kick up a fuss about it.
>

Its a build system that apparently doesnt support the symver trick.

/usr/bin/ld: error: symbol av_free_packet has undefined version LIBAVFORMAT_52

Is there a way to disable the compatibility code?  The ifdef is done like
this:

libavformat/utils.c

#if LIBAVFORMAT_VERSION_MAJOR < 53 && CONFIG_SHARED && HAVE_SYMVER

HAVE_SYMVER is auto detected.

Extend the version check to check minor as well?

Index: libavformat/utils.c
===================================================================
--- libavformat/utils.c (revision 23877)
+++ libavformat/utils.c (working copy)
@@ -283,7 +283,7 @@
     return NULL;
 }

-#if LIBAVFORMAT_VERSION_MAJOR < 53 && CONFIG_SHARED && HAVE_SYMVER
+#if LIBAVFORMAT_VERSION_MAJOR < 53 && LIBAVFORMAT_VERSION_MINOR < 68 &&
CONFIG_SHARED && HAVE_SYMVER
 FF_SYMVER(void, av_destruct_packet_nofree, (AVPacket *pkt),
"LIBAVFORMAT_52")
 {
     av_destruct_packet_nofree(pkt);



> --
> M?ns Rullg?rd
> mans at mansr.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>