[FFmpeg-devel] [PATCH] strict-aliasing-safe aes.c

[Michael Niedermayer]

On Mon, Jun 28, 2010 at 05:55:30PM +0200, Reimar D?ffinger wrote:
> Hello,
> this uses AV_WN32A, AV_WN64A etc. macros.
> The generated code is the same on x86_64 (assuming I did not mess up that test).

>  aes.c |   20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 76705b63949d4abbe51b0d7d59537045ae91179a  aesalias.diff

this makes the code unreadable, iam thus against it.
Also its missing a benchmark

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100628/0682b6c2/attachment.pgp>