[FFmpeg-devel] [PATCH] Fix clang warning in libavfilter/vf_unsharp.c

[Michael Niedermayer]

On Sun, Jun 27, 2010 at 05:09:51PM -0700, Eli Friedman wrote:
> 2010/6/27 M?ns Rullg?rd <mans at mansr.com>:
> > Eli Friedman <eli.friedman at gmail.com> writes:
> >
> >> On Sun, Jun 27, 2010 at 3:47 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >>> On Sun, Jun 27, 2010 at 11:17:30AM -0700, Eli Friedman wrote:
> >>>> Patch attached; clang warns on " =- " because it looks like a typo for " -= ".
> >>>
> >>> can you also fix our patcheck so it detects these?
> >>
> >> Attached.
> >>
> >> -Eli
> >>
> >> Index: tools/patcheck
> >> ===================================================================
> >> --- tools/patcheck ? ?(revision 23833)
> >> +++ tools/patcheck ? ?(working copy)
> >> @@ -42,6 +42,7 @@
> >> ?hiegrep 'for *\( *'"$ERE_PRITYP"' ' ?'not gcc 2.95 compatible' $*
> >> ?hiegrep '(static|inline|const) *\1' ?'duplicate word' $*
> >> ?hiegrep 'INIT_VLC_USE_STATIC' 'forbidden ancient vlc type' $*
> >> +hiegrep ' =[+-] ' 'looks like compound increment/decrement' $*
> >
> > The correct term is "compound assignment", and checking for a few more
> > of them might be a good idea if we're going to be doing this at all.
> 
> Updated version addressing comments.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100628/e2a4ef79/attachment.pgp>