[FFmpeg-devel] [PATCH] vc1dec: fix sign of pointer-to-scantable variables

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> Hello,
> the scantables only contain positive values < 128 and their type is uint8_t.
> As such I think the zz_table variables in vc1dec.c should be uint8_t
> as well instead of int8_t.
>
> Index: libavcodec/vc1dec.c
> ===================================================================
> --- libavcodec/vc1dec.c (revision 23830)
> +++ libavcodec/vc1dec.c (working copy)
> @@ -1481,7 +1481,7 @@
>
>      {
>          int last = 0, skip, value;
> -        const int8_t *zz_table;
> +        const uint8_t *zz_table;
>          int scale;
>          int k;
>
> @@ -1667,7 +1667,7 @@
>
>      if(coded) {
>          int last = 0, skip, value;
> -        const int8_t *zz_table;
> +        const uint8_t *zz_table;
>          int k;
>
>          if(v->s.ac_pred) {
> @@ -1874,7 +1874,7 @@
>
>      if(coded) {
>          int last = 0, skip, value;
> -        const int8_t *zz_table;
> +        const uint8_t *zz_table;
>          int k;
>
>          zz_table = wmv1_scantable[0];

I agree.

-- 
M?ns Rullg?rd
mans at mansr.com