[FFmpeg-devel] [PATCH] Change broken -Werror=implicit flag in configure into working flag

[Michael Niedermayer]

On Sun, Jun 27, 2010 at 11:52:57AM +0100, M?ns Rullg?rd wrote:
> Martin Storsj? <martin at martin.st> writes:
> 
> > On Sun, 27 Jun 2010, M?ns Rullg?rd wrote:
> >
> >> Eli Friedman <eli.friedman at gmail.com> writes:
> >> 
> >> > Patch attached.  At least with gcc 4.4.3, -Werror=implicit does
> >> > nothing, and -Werror=implicit-int does not work with -std=c99.
> >> >
> >> > The configure change exposes an error in ffserver.c, so I patched that
> >> > as well; I'm not sure if this is the best fix, though.  The function
> >> > in question is ff_url_split.
> >> >
> >> > -Eli
> >> >
> >> > Index: ffserver.c
> >> > ===================================================================
> >> > --- ffserver.c	(revision 23802)
> >> > +++ ffserver.c	(working copy)
> >> > @@ -29,6 +29,7 @@
> >> >  #include <strings.h>
> >> >  #include <stdlib.h>
> >> >  #include "libavformat/avformat.h"
> >> > +#include "libavformat/internal.h"
> >> 
> >> That is strictly verboten.  I've tried to make people fix this
> >> properly, but they all ignored me.
> >> [...]
> >> I'd like to do that, but can't until ffserver is fixed.  And no,
> >> including lavf private headers is not allowed.  The API must be fixed.
> >
> > Stefano sent a patch doing that, making both ff_url_split and ff_url_join 
> > public, that stalled in a discussion on details regarding ff_url_join. 
> > The part making ff_url_split public should be ok as far as I remember, 
> > though.
> 
> ff_url_split() parts of the patch attached.

iam fine with this once it compiles and works

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100627/31761dee/attachment.pgp>