[FFmpeg-devel] [PATCH] Change broken -Werror=implicit flag in configure into working flag

[Martin Storsjö]

On Sun, 27 Jun 2010, M?ns Rullg?rd wrote:

> Martin Storsj? <martin at martin.st> writes:
> 
> > On Sun, 27 Jun 2010, M?ns Rullg?rd wrote:
> >
> >> > Stefano sent a patch doing that, making both ff_url_split and ff_url_join 
> >> > public, that stalled in a discussion on details regarding ff_url_join. 
> >> > The part making ff_url_split public should be ok as far as I remember, 
> >> > though.
> >> 
> >> ff_url_split() parts of the patch attached.
> >
> >> diff --git a/libavformat/utils.c b/libavformat/utils.c
> >> index e33cb50..ed02f0f 100644
> >> --- a/libavformat/utils.c
> >> +++ b/libavformat/utils.c
> >> @@ -3493,11 +3493,32 @@ void av_pkt_dump_log(void *avcl, int level, AVPacket *pkt, int dump_payload)
> >>      pkt_dump_internal(avcl, NULL, level, pkt, dump_payload);
> >>  }
> >>  
> >> +#if LIBAVFORMAT_VERSION_MAJOR < 53
> >> +/**
> >> + * @deprecated Use av_url_split() instead.
> >> + */
> >> +attribute_deprecated
> >>  void ff_url_split(char *proto, int proto_size,
> >>                    char *authorization, int authorization_size,
> >>                    char *hostname, int hostname_size,
> >>                    int *port_ptr,
> >>                    char *path, int path_size,
> >> +                  const char *url);
> >> +{
> >> +    av_url_split(proto, proto_size,
> >> +                 authorization, authorization_size,
> >> +                 hostname, hostname_size,
> >> +                 port_ptr,
> >> +                 path, path_size,
> >> +                 url);
> >> +}
> >> +#endif
> >> +
> >
> > Umm, this doesn't seem to compile for me at least.
> 
> Nor for me :-)  I've fixed it locally though.
> 
> > I guess the main bikeshed question is whether it should be named 
> > av_url_split or simply url_split (since we have a family of public 
> > functions named simply url_*). Ronald?
> 
> That family is badly named.  The url_ prefix is rather common in
> various apps and libraries, and the risk of a clash is substantial.
> If anything, the others should be renamed.

Good point, fair enough.

> > In lavf/internal.h, there's a few mentionings of ff_url_split that need to 
> > be changed accordingly too, and one use of ff_url_split in lavf/mmst.c 
> > that needs changing, too.
> 
> Yeah, I just noticed.

With those changes, I'm ok with it, but please wait for an ok from Ronald 
too.

// Martin

>From Diego  Sun Jun 27 14:23:44 2010
From: Diego (Diego)
Date: Sun, 27 Jun 2010 14:23:44 +0200
Subject: [FFmpeg-devel] [PATCH] tablegen: implement and use WRITE_ARRAY
 macros
In-Reply-To: <yw1x39w8lobu.fsf at unicorn.mansr.com>
References: <1277630555.11106.55.camel at yamato>
	<1277634017-9157-1-git-send-email-flameeyes at gmail.com>
	<20100627102325.GA2092 at 1und1.de> <1277635440.11106.57.camel at yamato>
	<yw1x39w8lobu.fsf at unicorn.mansr.com>
Message-ID: <1277641424.11106.58.camel at yamato>

Il giorno dom, 27/06/2010 alle 12.14 +0100, M?ns Rullg?rd ha scritto:
> 
> Setting indent-tabs-mode to nil takes care of that once and for all.
> 
I used not to set that because other projects I followed wanted tabs...
now I don't think there is any so it's a good suggestion indeed.
Done! :D
> 
-- 
Diego Elio Petten? ? ?Flameeyes?
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/