[FFmpeg-devel] [PATCH] adpcm: convert VLAs to malloc/free
Michael Niedermayer
michaelni
Sun Jun 27 02:59:11 CEST 2010
On Sun, Jun 27, 2010 at 01:40:38AM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
>
> > On Wed, Jun 23, 2010 at 08:49:53PM +0100, Mans Rullgard wrote:
> >> ---
> >> libavcodec/adpcm.c | 136 +++++++++++++++++++++++++++++++---------------------
> >> 1 files changed, 82 insertions(+), 54 deletions(-)
> >
> > mixes functional and cosmetic changes
>
> No, moving the structs is necessary.
that may be but i dont think moving the structs needs the rest of the changes
that said the removial of VLAs here does lead to ugly code ... iam not really
happy about it.
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100627/f5878374/attachment.pgp>
More information about the ffmpeg-devel
mailing list