[FFmpeg-devel] [PATCH] Change all instances of "inofficial" to "unofficial" (except c/l option in lavc/options.c)

[Rodney Baker]

On Sun, 27 Jun 2010 00:27:09 Rodney Baker wrote:
> On Wed, 23 Jun 2010 23:50:18 Rodney Baker wrote:
> > On Wed, 23 Jun 2010 20:33:07 Diego Biurrun wrote:
> > > On Wed, Jun 16, 2010 at 06:40:34AM +0200, Michael Niedermayer wrote:
> > > > On Wed, Jun 16, 2010 at 07:59:57AM +0930, Rodney Baker wrote:
> > > > > On Wed, 16 Jun 2010 02:36:48 Michael Niedermayer wrote:
> > > > > > On Wed, Jun 16, 2010 at 01:40:32AM +0930, Rodney Baker wrote:
> > > > > > > $Subj.
> > > > > > > 
> > > > > > > --- libavcodec/avcodec.h	(revision 23615)
> > > > > > > +++ libavcodec/avcodec.h	(working copy)
> > > > > > > @@ -1361,7 +1361,7 @@
> > > > > > > 
> > > > > > > -#define FF_COMPLIANCE_INOFFICIAL   -1 ///< Allow inofficial
> > > > > > > extensions. +#define FF_COMPLIANCE_UNOFFICIAL   -1 ///< Allow
> > > > > > > unofficial extensions.
> > > > > > 
> > > > > > breaks API
> > > > > > 
> > > > > > [...]
> > > > > 
> > > > > Is it OK to do this at the next major version bump, then, or not?
> > > > > 
> > > > > (i.e. #if LIBAVCODEC_MAJOR_VERSION < 53 ...)
> > > > 
> > > > if the spelling ppl make a big fuzz of it then i dont mind
> > > > otherwise iam leaning toward not burdening applications with an
> > > > additional
> > > > 
> > > >  change
> > > 
> > > I suggest changing it.  Typos are always counterintuitive and make an
> > > API harder to use.
> > > 
> > > Diego
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel at mplayerhq.hu
> > > https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
> > 
> > OK - I will try to get to it this weekend and have an updated patch ready
> > for next week (it is the end of our financial year and I've had zero time
> > to work on anything other than "real" (paid) work for the last week or
> > two).
> 
> Updated patch -
> 
> -adds "unofficial" command line option and keeps "inofficial" until next
> major version bump
> - adds FF_COMPLIANCE_UNOFFICIAL and keeps existing symbol until next major
> version bump (and bumps minor).
> - changes all uses of FF_COMPLIANCE_INOFFICIAL that I could find in the
> source tree (there weren't many) to use _UNOFFICIAL.
> 
> Patcheck didn't complain of anything and make test passes.

Opps - I noticed a minor error in the last one after it hit the list. This one 
has been corrected. Sorry for the noise.

-- 
===================================================
Rodney Baker VK5ZTV
rodney.baker at iinet.net.au
=================================================== 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: inofficial-20100626.patch
Type: text/x-patch
Size: 7048 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100627/ff769a59/attachment.bin>